Adds 'with' to the bootstrapping docs to help clarify how to build a new compiler #2368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
this is a good change, and it exposes text that is almost exactly duplicated... are you happy to remove/reduce that, or would you rather that happen in a different pr |
Member
|
will defer that to a future pr... no need to delay this |
Contributor
Author
|
@tshepang thanks for the review 🙏 . I had noticed the paragraph is duplicated word for word across both files. I had thought about removing the second occurrence, but wasn't sure if this was intended. If we were to go forward with this, the two options that make sense to me are:
Let me know what makes sense and I can make the quick change. |
Member
|
or 2a, add a link to that bit of text |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sentence
feels like it's grammatically missing the preposition 'with', as well as some commas around "However" etc.